PigeonBar
63ffab027d
[Beta][P2] Several Unburden bug fixes ( #4820 )
...
* [P2][Beta] Several Unburden bug fixes
* Unburden test adjustments
* Some further test cleanup
* Add suggested `.bypassFaint()` to Unburden
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-11-10 14:21:29 -05:00
NightKev
2968059814
[P1] Transform and Imposter will now fail when either Pokemon is fused ( #4824 )
...
* Transform and Imposter will now fail when either Pokemon is fused
* Prevent Ditto from being randomly generated as part of a fusion
2024-11-10 00:39:05 -05:00
NightKev
00f7fd47df
[Refactor] Remove unnecessary re-exports ( #4818 )
...
* Remove unnecessary re-exports
* Move `Type` enum to `src/enums/type.ts`
* Remove import style change from `modifier-type.ts`
2024-11-08 17:44:34 -05:00
innerthunder
625b98a6fe
[Move][Refactor] Create Move.getPriority + Fully Implement Upper Hand ( #4789 )
...
* Fully Implement Upper Hand
* doc for UpperHandCondition
* New Upper Hand tests + some nit fixes
* Use Fake Out over mocked Tackle in test
2024-11-08 10:50:23 -05:00
Mumble
6b7efb444b
[Ability] Fully implement Synchronize ( #4785 )
...
Co-authored-by: frutescens <info@laptop>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-11-06 11:29:24 -05:00
innerthunder
eb32545772
[Balance][Beta] Commander now increases double battle chance ( #4803 )
2024-11-05 11:23:22 -08:00
geeilhan
198d3ce2a6
[P2] Fixing Incorrect Freeze Dry Interaction With Soaked Wonder Guard Target ( #4798 )
...
* [Bug] fixed interaction between freeze dry and soaked wonder guard target
* added automated test for freeze dry interaction with soaked wonder guard target
* using parameter instead of function to get typeMultiplier
2024-11-05 12:37:47 -05:00
innerthunder
6fd3ba284c
[Move][Ability] Implement Commander and Order Up ( #4670 )
...
* Implement Order Up (mostly untested)
* Commander unit tests + bug fixes
* Implement Order Up (misnamed the other commit...)
* Order Up unit tests
* applying Temp's suggestions + other bugfixes
* add TODO comment
* Reviver Seed reapplies Commander
* ESLint woes
* Some animation fixes
* Update locales
* Order Up now uses attr option
* Prevent semi-invulnerability lapsing out while Commanding
* semi-invulnerability test
* Add `edgeCase`
2024-11-05 12:35:43 -05:00
Adrian T.
88789c685e
[Documentation] Flag Gulp Missile with edge case ( #4800 )
2024-11-05 11:08:55 -05:00
muscode
3f97c9e39f
[Ability] Implement Unburden ( #4534 )
...
* unburden implemented
* Used tag instead of stat changes for Unburden
* added documentation and neutralizing gas test
* accounted for unburden in getEffectiveStat
* fixed doubling speed in two places
* merge conflict resolve
* changed documentation wording, added test for stuff cheeks
* refactor unburden
* merge
* remove console logs
* Update src/data/ability.ts
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* add neut gas check
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* Added test for NeutGas user entering while unburden activated
* add spaces to tests, removed passive and [] from applyPostItemLostAbAttrs
* added line breaks after test cases
---------
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-11-03 21:58:12 -05:00
NightKev
af473ba4ff
[Refactor] Clean up various methods in battle-scene.ts and pokemon.ts ( #4412 )
...
* Update `battle-scene.ts` and `data/field/pokemon.ts`
`battle-scene.ts` changes:
- `getParty()` renamed to `getPlayerParty()` for clarity
- `getNonSwitchedXPokemon()` consolidated into `getXPokemon()`
- Some tsdocs were added/updated for
`getXParty()`, `getXField()` and `getXPokemon()`;
and those functions were explicitly marked as `public`
- Helper function `getPokemonAllowedInBattle()` added
`pokemon.ts` changes:
- `isAllowed()` renamed to `isAllowedInChallenge()` for clarity
- A redundant check for an active scene is removed in `isActive()`
- Some tsdocs were added/updated for `isFainted()`,
`isAllowedInChallenge()`, `isAllowedInBattle()` and `isActive()`;
and those functions were explicitly marked as `public`
- `isFainted()` now checks for `hp <= 0` instead of `!hp`
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Backport eslint change to reduce merge conflicts
* Fix merge issues
---------
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
2024-11-03 21:53:52 -05:00
Tempoanon
87b7122b60
[P2] Illuminate ignores evasion ( #4781 )
2024-11-03 21:47:07 -05:00
NightKev
5e2dfa975a
Rename PokemonTurnData's damageDealt and currDamageDealt ( #4784 )
2024-11-03 14:09:28 -08:00
muscode
f0ae36de6c
[Ability] Implement Wimp Out and Emergency Exit ( #4701 )
...
* implement Wimp Out/Emergency Exit
* fixed test
* fixed weather bug
* Added nightmare interaction to Wimp Out following bug fix
* refactored and added postdamageattr
* bug fixes
* added confusion test back (skipped)
* updated applyPostDamageAbAttrs to applyPostDamage
* fix external func name
* fixed syntax inconsistency
* updated PostDamageForceSwitchAttr -> PostDamageForceSwitchAbAttr
* Modify `wimp_out.test.ts`
* remove extra comment
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* remove extra comment
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* remove comment
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* remove comment
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix whitespace
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make getFailedText public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make switchOutLogic public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make getSwitchOutCondition public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make getFailedText public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make applyPostDamage public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* simplify if statement
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* add public override to applyPostDamage
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fixed nested if issue, remove trapped tag removal
* add fix for multi hit move
* added multi-lens logic
* moved applyPostDamageAbAttrs to pokemon.damage, added check for multi lens in pokemon.apply
* added source to damageAndUpdate and applyPostDamageAbAttrs, added Parental Bond logic + test, put applyPostDamageAbAttrs back in damageAndUpdate
* simplify multi hit check
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* Minor formatting changes
* Update src/data/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* moved and renamed shouldPreventSwitchOut, rewrote tests to account for U-turn changes, fix syntax error
* Move comment slightly
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-11-03 01:04:20 -05:00
Mumble
f16309fd06
[P2] Plus, Minus, Beads/Sword of Ruin not ignorable. Shield Dust and Armoa Veil ignorable ( #4778 )
...
Co-authored-by: frutescens <info@laptop>
2024-11-03 01:22:40 -04:00
PrabbyDD
afe6d2900d
[P2] Fix for Speed Boost is Activated on the Turn a Pokemon is Switched In, and When a Pokemon Fails to Escape #4353 ( #4676 )
...
* fixing speed boost for pokemon being switched in and for if failed escape
* adding unit tests
* adding failed run away test case
* adding failed run away test case modification
* refactoring solution to be more consistent with coding style
* more fixes for consistency
* more fixes for consistency
* adding new AbAttr in abiliity.ts for posterity
* removing uneccesary variables
* fixing a merge conflict
2024-10-29 17:38:33 -04:00
NightKev
13ff80fb95
Mark Last Respects as partial ( #4749 )
2024-10-29 18:59:28 +01:00
Mumble
fb2d3e45d6
[Move][Ability] Fully Implement Forest's Curse / Trick Or Treat / Mimicry ( #4682 )
...
* addedType variable
* basic mimicry implementation
* eslint
* rage
* quick change
* made files
* added mimicry activation message
* test for moves done
* hahahhaha
* done? for now?
* laklhaflhasd
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* time to start... ughhh
* reflect type
* Added new message
* Update src/field/pokemon.ts
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* added overrides
* some checks
* removed comments
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-10-29 10:10:37 -07:00
PrabbyDD
3241332a3c
[Ability] Implementing Friend Guard ( #4718 )
...
* implementing friend guard ability
* Update src/data/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/test/abilities/friend_guard.test.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* more tests and fixing other issues
* more tests and fixing other issues
* Update Friend Guard test with damage mocks
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
Co-authored-by: innerthunder <brandonerickson98@gmail.com>
2024-10-28 13:49:04 -07:00
PigeonBar
f87ac116fa
[Beta] Stop Transform giving copied moves negative fractional ppUp ( #4722 )
...
* [Beta] Stop Transform giving copied moves negative fractional `ppUp`
* Remove some bangs/etc
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-10-25 19:34:40 -04:00
schmidtc1
958d79140c
[P2] Fixes Transform/Imposter not updating type/battle stat changes immediately; set move PP to 5 when transforming ( #3462 )
...
* Adds updateInfo to transform move/ability, mirrors Transform functionality in Imposter
* Implements functionality for reducing pp to 5 or less for each move when transforming
* Refactors to async/await pattern, adds back removed anims/sounds from last commit
* Eslint fix attempt
* Update src/data/ability.ts
per DayKev's suggestion
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Merge and fix conflicts
* Adds unit tests for pp-change with transform/imposter
* Updates to consistency in syntax/deprecated code
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-10-23 11:12:53 -04:00
innerthunder
03025b2674
[P2] Fix various charge move bugs ( #4595 )
...
* Add charge move classes and phase
* Integrate `MoveChargePhase` in battle phase sequence
* Fix Protean + charge move interaction
* Fix effect chance applying to semi-invulnerability
* Remove `ChargeAttr` and fix ChargeAnim loading
* Restore move history entry for charge phases
* Gravity now cancels Fly, etc. after charge turn
* Dig integration tests
* Fly integration tests
* Dive integration test + fix Dive in Harsh Sun bug
* Solar Beam integration tests + `CHARGING` tag fixes
* Fix dive test
* Electro Shot integration tests
* fix import in MoveChargePhase
* Electro Shot Multi Lens test
* Geomancy integration tests
* Fix duplicate move queue
* Update import
* Docs + Fix Meteor Beam being boosted by Sheer Force
* Fix volt absorb test
* Apply PigeonBar's suggested move-phase changes
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* Make Electro Shot Sheer Force boosted again
* Apply PigeonBar's feedback pt. 2
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fix mistimed/dupe showMoveText and leftover TODO
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
2024-10-23 11:08:40 -04:00
NightKev
181f59882a
[P2] Fix Early Bird ( #4632 )
...
* Fix Early Bird, add tests
* Update tsdocs for Early Bird's `AbAttr`
Rename `turnCount` to `toxicTurnCount` and
`turnsRemaining` to `sleepTurnsRemaining` in `status-effect.ts`
* Fix Toxic Orb test
* Redundant code :despair:
* Fix status override to set the number of sleep turns
2024-10-22 12:37:13 -04:00
innerthunder
c2eb9de9df
[Ability] Partially Implement Infiltrator (does not work with mist) ( #4636 )
...
* Implement Infiltrator
* Integration tests + Infiltrator is (P) again
* Fix screen tests
* Fix `hitsSubstitute`
* docs for Infiltrator attr
2024-10-21 21:41:25 -04:00
NightKev
39abac65be
Add eslint rule to enforce indenting of case statements ( #4692 )
2024-10-20 02:44:36 +01:00
Mumble
2f212f52eb
fixed effectChanceOVerrride location + removed ability tags ( #4677 )
...
Co-authored-by: frutescens <info@laptop>
2024-10-16 23:31:30 -07:00
Madmadness65
c04d81bd65
[Ability] Allow Power Construct to transform 10% PC Zygardes ( #4626 )
...
* Allow Power Construct to transform 10% PC Zygarde
* Add additional test for 10% PC Zygarde
2024-10-15 15:02:30 -04:00
Tempoanon
391f38c3c8
[Documentation] Document all (P) abilities ( #4649 )
...
* Document partial abilities
* Fix typo
* Address comments
* Fix typo Terapagos -> Ogerpon
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-10-13 00:45:38 -04:00
NightKev
ba7e26152e
[Bug] Fix substitute interactions with PostDefendAbAttrs ( #4570 )
...
* Fixes some Substitute interactions
Specifically with Disguise/Ice Face and Gulp Missile
* Add tests
* Fix linting
* Add `hitsSubstitute()` checks to all `PostDefendAbAttr`s
Also fix comment indentation in `MoveEffectPhase`
* Revert `move-effect-phase.ts` changes
2024-10-10 11:45:02 -04:00
Xavion3
f562a76332
Make repeat abilities not stack ( #4588 )
...
If due to fusions you have the same ability as both passive and normal, it'll no longer stack with itself.
2024-10-05 15:10:32 +08:00
torranx
644c078a6c
add new lint rules....again
2024-10-04 13:08:31 +08:00
innerthunder
7473c31c77
[P2] Fix Tera Shell to apply to all hits of multi-strike moves ( #4541 )
...
* Apply Tera Shell to all hits for multi-hit moves
* fix undefined property error
* ugh
* Remove obsolete bangs
2024-10-01 21:58:56 -04:00
NightKev
8a8adad7fe
[Refactor] Clean up some TODOs from the strict-null refactor ( #4267 )
2024-09-30 13:11:45 -04:00
Adrian T.
4c327e9e63
[Ability] Refactor Gulp Missile and make it trigger when Cramorant faints ( #4428 )
...
* reimplement gulp missile
* cleanup + docs
* more cleanup
* add override
* update paths
2024-09-29 21:57:50 -04:00
innerthunder
7339facae1
[Ability] Remove (P) from Super Luck ( #4498 )
2024-09-29 21:54:49 -04:00
Mumble
57f39efdae
[Moves][Ability] Implement Torment / Taunt / Imprison + Aroma Veil ( #4378 )
...
* Torment
* Taunt and Imprison
* ability immunities
* Aroma Veil
* Imprison
* Test Files
* Added exceptions for Rollout and check for active ability
* adding tests so that git doesn't auto-fail
* Blah
* please
* some documentation
* Removed random newlines
* Added check for ability's presence mid battle
* Changed BattlerTagImmunityAbAttr to look at lists instead
* Work?
* Imprison and Taunt Tests
* Tests
* Final tests before documentation
* documentation blah
* Imports
* Flx Change
* flx - adding overrides
* Update src/data/arena-tag.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* flx fixes
* quick docs
* privated retrieveField
* Handling undefined
* Update src/data/arena-tag.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* forget to remove partials for heal block
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Marked Torment as partial
* Update src/test/moves/torment.test.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* tsdocs
* Prevents test pokemon from being immune to torment
* Update src/data/arena-tag.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
* Torranx Fixes
* Check for this.source
* why
* lighting things with my mind on fire
* aRHGHSHDKSHD
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
2024-09-25 14:52:48 -07:00
PrabbyDD
3d4eadbc3e
[Bug] Flash Fire/etc now trigger even if the attack would miss ( #4337 )
...
* adding immunity check
* making tests
* modifying and adding tests
* making tests more rigorous
* changing hitcheck return to be what it was originally, no significant effect
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-23 15:37:21 -04:00
Tempoanon
b9b69ad834
[Move] Implement autotomization weight effects ( #4228 )
...
* Implement Autotomize
* Another linting
* Fix unit tests
* Add nonnull after checking for null
* Update autotomize test
---------
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-23 11:42:17 -04:00
Yiling Kang
b9b2491f95
[Ability] (Partially) Implement synchronize ability with old psycho shift interaction ( #2746 )
...
* Initial changes for Synchronize ability
* Fix psycho shift interaction causing buggy behaviour
* Update to show ability even if opponent pokemon does not get statused
* Fix some spacing
* Update tests
* Formatting change
* Remove impossible `if` statement
* Add `simulated` support
* Apply suggestions from code review
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* Don't need those comments
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-09-22 19:38:09 -07:00
innerthunder
3ef02c9bbd
[Balance] Remove Species Locks from Aura Wheel and Poison Puppeteer ( #4330 )
...
* Remove non-form-change species locks
* Fix typo in localization
* Mark descriptions that need changes
* Update ability.json
* Update move.json
* Update ability.json
* Update src/locales/pt_BR/ability.json
* Update src/locales/pt_BR/move.json
* KO translations
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
* Update src/locales/de/ability.json
* Update src/locales/de/move.json
* Update src/locales/de/move.json
* Update ability.json
* Update move.json
* Update src/locales/it/move.json
* Update src/locales/it/ability.json
* Update src/locales/ja/move.json
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
* Update src/locales/ja/ability.json
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
* Update src/locales/es/ability.json
Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>
* Update move.json
* Update src/locales/zh_CN/ability.json
Co-authored-by: btsrkex <34084904+btsrkex@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: btsrkex <34084904+btsrkex@users.noreply.github.com>
---------
Co-authored-by: Lugiad <adrien.grivel@hotmail.fr>
Co-authored-by: José Ricardo <josefleury@discente.ufg.br>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>
Co-authored-by: btsrkex <34084904+btsrkex@users.noreply.github.com>
2024-09-22 20:07:35 +02:00
Amani H.
612dcc5f27
[Balance] Adjust Relevant Abilities to Match Lures ( #4231 )
...
* [Balance] Adjust Relevant Abilities to Match Lures
* Add Relevant Unit Tests
2024-09-21 21:40:47 -04:00
Mumble
4fb76fd117
[Move] Implement Heal Block ( #4120 )
...
* Heal Block on new branch
* Add/update code from previous PR
* Re-add i18n from previous PR
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Asdar <asdargmng@gmail.com>
* Disabling Moves
* Still need to update tests and write docs
* removing partial tags from abilities to feel better
* Pollen Puff works now
* Implemented Psychic Noise
* typedocs
* Documentation
* Update src/data/battler-tags.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/data/battler-tags.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/data/battler-tags.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Turns out the old condition wasn't buggy. Probably mixed up another change I made.
* changed array clear
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Asdar <asdargmng@gmail.com>
2024-09-21 13:15:32 -07:00
ImperialSympathizer
5888a7758c
Mystery Encounter bug fixes and minor adjustments ( #4299 )
...
* various bug fixes for MEs
* various bug fixes for MEs
* fix final isTransferable rename that was missed
* change Trainer's test vouchers for second option
* change unit test skips
* cut down excess ME track length and loop properly
* ME bug fix cleanup
* updating AI for Slumbering Snorlax ME, and small ME balance changes
* fix ts error
* fix bug type superfan dialogue discrepancy
* ME bug fixes PR feedback
* ME PR nits and fixes
---------
Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-09-19 14:44:10 +01:00
flx-sta
4389bff5d0
[Bug] Fix stat-protection-attribute not taking inverts (e.g. Contrary) into account ( #4031 )
...
* add generic types to`Pokemon.getAbilityAttrs()`
* add invert check to `ProtectStatAbAttr.apply...`
This makes sure that a stat is only protected if no other ability inverts the change. E.g. `Contrary` inverts any decrease to an increase
* migrate contrary.test.ts to game.classicMode
* move `StatStageChangeMultiplierAbAttr` resolve above `ProtectStatAbAttr`
The effect of StatStageChangeMultiplierAbAttr is now applied before resolving any ProtectStatAbAttr. Thus the stage (level) of the BattleStat change was properly altered at the time of resolving the protection
* revert ability.ts changes
* add automated tests for `Clear Body` + `Contrary`
* StateStageChangePhase replace ~~`IntegerHolder`~~ with `NumberHolder`
Update Utils import and replace all occurcences of `Utils.`
* contrary.test.ts: remove `js` import
2024-09-17 19:14:41 -07:00
innerthunder
8164ec596e
[Balance] Remove isMax conditions from move and ability effects ( #4200 )
...
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Amani H. <109637146+xsn34kzx@users.noreply.github.com>
2024-09-13 20:48:57 -07:00
innerthunder
70295280da
[Move] Implement Substitute ( #2559 )
...
* Implement Substitute
Squashed commit from working branch
* Fix integration test imports
* Use Override Helper utils + Fix Baton Pass test
* Update src/test/moves/substitute.test.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
* Fix test imports + nits
* Document RemoveAllSubstitutesAttr
* Fix some strict-null issues
* more strict-null fixes
* Fix baton pass test
* Reorganized Substitute translation keys
* Added checks for substitute in contact logic
* Clean up Unseen Fist contact logic
* Remove misleading comment in Download attr
* RIP phases.ts
* Fix imports post-phase migration
* Rewrite `move.canIgnoreSubstitute` to `move.hitsSubstitute`
* Also fixed interactions with Shell Trap and Beak Blast
* Removed some leftover `canIgnoreSubstitute`s
* fix issues after beta merge
* Status move effectiveness now accounts for substitute
* More edge case tests (Counter test failing)
* Fix Counter + Trap edge cases + add Fail messagesd
* Fix leftover nit
* Resolve leftover test issues
* Fix Sub offset carrying over to Trainer fights
* Hide substitute sprite during catch attempts
* Make substitutes baton-passable again
* Remove placeholder locale keys and SPLASH_ONLY
* Fix imports and other nits
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* ESLint
* Fix imports
* Fix incorrect `resetSprite` timing
* Fix substitute disappearing on hit (maybe?)
* More animation fixes (mostly for Roar)
---------
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-13 12:46:22 -04:00
Adrian T.
a82d64b5b5
[Ability] Implement Gorilla Tactics ( #4051 )
...
* fully implement gorilla tactics
* fix atk increase
* update oversight
* add showAbility param
* fix postmerge
* fix postmerge
* update tests
2024-09-09 15:41:53 -04:00
Taylor Le Lievre
8df7422e8f
[Bug] Primal weather no longer persists if last mon dies to indirect damage ( #3492 )
...
* Fixed Delta Stream remaining active when last mon dies to indirect damage
* Rebasing changes
* Linting fix
* Combined if statements
* Changed params to optional
* Added unit test
* Apply suggestions from code review
* Fix test and remove `.js` from import
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-09 12:59:58 -04:00
innerthunder
7b97657756
[Bug] Fix Aura Break applying without Dark/Fairy Aura present ( #4057 )
...
* Fix Aura Break ignoring active Dark/Fairy Aura condition
* Add conditional post-summon message
---------
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-06 07:59:22 +00:00
NightKev
57a3efd9e2
[Bug] Fix off-by-one errors in some random number calls ( #3665 )
...
* Fix off-by-one error in some random number calls
* Fix mock RNG function used by tests
Also remove unnecessary extra RNG mock from Glaive Rush test
* Just some github UI manipulation don't mind me
* Update Glaive Rush test
* Remove unnecessary `Math.floor()`
* Remove resolved comment
* Add tsdocs to various functions
* Remove `src/rng.md` file
* Update tsdoc
2024-09-05 23:51:05 +00:00
