Bertie690
5fed690187
[Bug] Fixed Super Fang interaction with Multi Lens ( #4914 )
...
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-11-30 01:47:47 -08:00
Madmadness65
5992564842
Hotfix Forest BGM loop point
...
It sounds less jarring now, loops a couple seconds earlier.
2024-11-29 20:07:31 -06:00
Madmadness65
34cb234159
[Audio] Replace Forest track with custom BGM by Andr06 ( #4924 )
2024-11-29 17:57:12 -08:00
NightKev
4c8a18690e
[Misc] Rename DamagePhase to DamageAnimPhase ( #4880 )
...
* Rename `DamagePhase` to `DamageAnimPhase`
* Fix unreliable Speed Boost test
2024-11-25 14:15:39 -08:00
NightKev
dd904fe782
[Hotfix] Prevent crash if enemy Future Sight user is caught ( #4905 )
2024-11-17 18:08:00 -08:00
Moka
33d8db73ef
[P1] Fix crash caused by removing arena tags on a new catch ( #4888 )
2024-11-17 16:35:14 -05:00
PigeonBar
07f08877c1
[Balance] Multi Lens damage reduction on fixed-damage moves ( #4896 )
2024-11-17 17:16:54 +00:00
Daniel Pochert
7dc4210f71
[Bug] fix training session encounter not applying nature correctly ( #4801 )
...
* fix training session encounter not applying nature correctly
* implement pokemon.setCustomNature + nature unlock utility method(s)
* update doc
---------
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
2024-11-16 23:33:14 +00:00
innerthunder
360a897ed2
[Balance] Endure Tokens only endure one hit ( #4875 )
...
* Endure Tokens only endure one hit
* Add tests for Endure
* Update docs
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-11-15 21:11:46 +01:00
pom-eranian
5ca1fd5cfd
[Sprite] Set default fps to 10 instead of 12 on pokemon animations ( #4842 )
...
* Set default fps to 10 instead of 12 for pokemon sprites
* [Sprite] Set pokemon animation framerate to 10 where assigned
2024-11-15 11:58:50 -05:00
PigeonBar
b1138c1d70
[P2][Beta] Freeze-dry Re-implementation ( #4874 )
2024-11-14 21:07:19 -08:00
innerthunder
cebedd220b
[Balance] Rework Multi-Lens ( #4831 )
...
* Rework Multi-Lens
* Multi-Lens integration tests
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fix obsolete tests related to Multi-Lens
* Fix flaky unburden tests
* maybe fix flaky ceaseless edge test?
* Fixed Multi-Lens apply comment
* Fix ceaseless edge test for real this time
* Update locales
* Another locale update
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-11-11 14:56:16 -08:00
PigeonBar
efa9f119a0
[Beta][P3] Fix shiny Pokemon being displayed before shiny colours are loaded ( #4843 )
2024-11-11 02:18:57 -05:00
PigeonBar
63ffab027d
[Beta][P2] Several Unburden bug fixes ( #4820 )
...
* [P2][Beta] Several Unburden bug fixes
* Unburden test adjustments
* Some further test cleanup
* Add suggested `.bypassFaint()` to Unburden
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-11-10 14:21:29 -05:00
NightKev
2968059814
[P1] Transform and Imposter will now fail when either Pokemon is fused ( #4824 )
...
* Transform and Imposter will now fail when either Pokemon is fused
* Prevent Ditto from being randomly generated as part of a fusion
2024-11-10 00:39:05 -05:00
Moka
44a68a91ba
[P1] Fix crash when newly aquired Pokemon are sent in battle ( #4835 )
2024-11-10 00:35:49 -05:00
PigeonBar
2bf8acea06
[Beta][P2] Fix Sketch failing to sketch moves that call other moves virtually ( #4823 )
...
* [P2][Beta] Fix Sketch failing to sketch Metronome et al
* Suggested changes to `getLastXMoves()`
* Renamed turnCount to moveCount
2024-11-09 13:15:24 -05:00
innerthunder
a763cd173d
[Beta][P1-3] Fix Commander implementation bugs ( #4826 )
2024-11-09 13:14:11 -05:00
innerthunder
329e43ad48
[P2] Removed incorrect calls to resetBattleData on switchout ( #4828 )
2024-11-09 13:13:12 -05:00
NightKev
00f7fd47df
[Refactor] Remove unnecessary re-exports ( #4818 )
...
* Remove unnecessary re-exports
* Move `Type` enum to `src/enums/type.ts`
* Remove import style change from `modifier-type.ts`
2024-11-08 17:44:34 -05:00
Daniel Pochert
aa2c794910
[Balance/Bug] Boss segments properly heal ( #4819 )
2024-11-07 23:09:25 -05:00
Mumble
4f733796c5
[Move] Implement Grudge ( #4794 )
...
* some work
* slay dnr
* Fixed up move mechanics
* bahhh
* yawn
* updated lapse type to correctness
* Test + documentation
* yattt
* Remove some redundant code
* Apply suggestions from code review
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* Update battler-tags.ts
* Fix `PokemonAnimPhase`
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-11-05 21:32:07 -05:00
innerthunder
6fd3ba284c
[Move][Ability] Implement Commander and Order Up ( #4670 )
...
* Implement Order Up (mostly untested)
* Commander unit tests + bug fixes
* Implement Order Up (misnamed the other commit...)
* Order Up unit tests
* applying Temp's suggestions + other bugfixes
* add TODO comment
* Reviver Seed reapplies Commander
* ESLint woes
* Some animation fixes
* Update locales
* Order Up now uses attr option
* Prevent semi-invulnerability lapsing out while Commanding
* semi-invulnerability test
* Add `edgeCase`
2024-11-05 12:35:43 -05:00
NightKev
a70f0860e1
[Beta Bug] Enemy pokemon shouldn't get unimplemented moves ( #4787 )
2024-11-03 23:34:26 -05:00
Mumble
3a767ed38a
[Refactor] Another Audio clean up ( #4077 )
...
* Cleaned up how cry keys were retrieved
* Legendary Pokemon Changes + Cry Cleanup
* Spelling mistake
* Fixed settings.
* correcting typedocs
* eslint
* eslint cleanup
* music pref
* gdfafa
* Music
* Apply suggestions from code review
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* Update src/battle.ts
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* Update src/battle.ts
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* fixed default
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Added changes
* Update src/battle-scene.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
* Fix variable usage
* Fix `getFormSpriteKey()` and `.concat()` usage
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* asdsafafaf
* i need to do the dishes ughhh
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
2024-11-03 22:31:07 -05:00
NightKev
770f388c45
[Refactor] Miscellaneous code cleanup ( #4596 )
...
* Miscellaneous code cleanup:
- Update `overrides.ts` imports
- Add missing comment and `;` in `eslint.config.js`
- `field/pokemon.ts`:
Rename `generateVariant` to `generateShinyVariant`
Mark some functions as `public`/etc
Update various tsdocs/comments, add tsdocs to `isOfType`
Turn an unreadable 450+ character line into a
readable block of code
- `utils.ts`:
Remove unused function `randSeedEasedWeightedItem`
Mark `IntegerHolder` and `FixedInt` as deprecated
Update some tsdocs/comments
* Convert to inline anonymous function
* Fix indentation in `move-effect-phase.ts`
Rename `getTarget` to `getFirstTarget` for clarity
Convert namespace import to named imports
Add `public`/etc to methods
* Rename `verifyLang` to `hasAllLocalizedSprite` and update tsdoc
* update locale submodule
* Put missing `null` guards around some uses of `getUserPokemon()`
* Fix locales
* Fix Unburden test
---------
Co-authored-by: Moka <millennium.stitcher@gmail.com>
Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
2024-11-03 22:23:51 -05:00
innerthunder
c3d832aaca
[Move] Fully Implement Round ( #4783 )
2024-11-03 21:59:55 -05:00
muscode
3f97c9e39f
[Ability] Implement Unburden ( #4534 )
...
* unburden implemented
* Used tag instead of stat changes for Unburden
* added documentation and neutralizing gas test
* accounted for unburden in getEffectiveStat
* fixed doubling speed in two places
* merge conflict resolve
* changed documentation wording, added test for stuff cheeks
* refactor unburden
* merge
* remove console logs
* Update src/data/ability.ts
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* add neut gas check
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* Added test for NeutGas user entering while unburden activated
* add spaces to tests, removed passive and [] from applyPostItemLostAbAttrs
* added line breaks after test cases
---------
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-11-03 21:58:12 -05:00
muscode
1619d512cf
[Move] Implement Fairy Lock ( #4736 )
...
* inital wip
* wip set isTrapped to true and removed timedtrap
* implement fairy lock
* whitespace fix
* added documentation for tag
* added more suggested tests
* give tests breathing room
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* give tests breathing room
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* give tests breathing room
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* updated nested ternary, changed test name
---------
Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-11-03 21:56:54 -05:00
NightKev
af473ba4ff
[Refactor] Clean up various methods in battle-scene.ts and pokemon.ts ( #4412 )
...
* Update `battle-scene.ts` and `data/field/pokemon.ts`
`battle-scene.ts` changes:
- `getParty()` renamed to `getPlayerParty()` for clarity
- `getNonSwitchedXPokemon()` consolidated into `getXPokemon()`
- Some tsdocs were added/updated for
`getXParty()`, `getXField()` and `getXPokemon()`;
and those functions were explicitly marked as `public`
- Helper function `getPokemonAllowedInBattle()` added
`pokemon.ts` changes:
- `isAllowed()` renamed to `isAllowedInChallenge()` for clarity
- A redundant check for an active scene is removed in `isActive()`
- Some tsdocs were added/updated for `isFainted()`,
`isAllowedInChallenge()`, `isAllowedInBattle()` and `isActive()`;
and those functions were explicitly marked as `public`
- `isFainted()` now checks for `hp <= 0` instead of `!hp`
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Backport eslint change to reduce merge conflicts
* Fix merge issues
---------
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
2024-11-03 21:53:52 -05:00
NightKev
5e2dfa975a
Rename PokemonTurnData's damageDealt and currDamageDealt ( #4784 )
2024-11-03 14:09:28 -08:00
muscode
f0ae36de6c
[Ability] Implement Wimp Out and Emergency Exit ( #4701 )
...
* implement Wimp Out/Emergency Exit
* fixed test
* fixed weather bug
* Added nightmare interaction to Wimp Out following bug fix
* refactored and added postdamageattr
* bug fixes
* added confusion test back (skipped)
* updated applyPostDamageAbAttrs to applyPostDamage
* fix external func name
* fixed syntax inconsistency
* updated PostDamageForceSwitchAttr -> PostDamageForceSwitchAbAttr
* Modify `wimp_out.test.ts`
* remove extra comment
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* remove extra comment
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* remove comment
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* remove comment
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix tsdocs
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fix whitespace
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make getFailedText public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make switchOutLogic public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make getSwitchOutCondition public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make getFailedText public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* make applyPostDamage public
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* simplify if statement
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* add public override to applyPostDamage
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* fixed nested if issue, remove trapped tag removal
* add fix for multi hit move
* added multi-lens logic
* moved applyPostDamageAbAttrs to pokemon.damage, added check for multi lens in pokemon.apply
* added source to damageAndUpdate and applyPostDamageAbAttrs, added Parental Bond logic + test, put applyPostDamageAbAttrs back in damageAndUpdate
* simplify multi hit check
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* Minor formatting changes
* Update src/data/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* moved and renamed shouldPreventSwitchOut, rewrote tests to account for U-turn changes, fix syntax error
* Move comment slightly
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-11-03 01:04:20 -05:00
podar
b17b1d6e7e
[P1] Fixing crash that can occur when failing to loading variant sprites. ( #4315 )
2024-11-03 01:33:48 -04:00
Mumble
1659f57262
[P2] Camouflage now considers Terrains first ( #4761 )
...
* the fix... will maybe write a test later
* ughh
* made a test
* moved aorund function
* Update src/test/moves/camouflage.test.ts
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* lalal
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
2024-11-02 12:48:10 -04:00
Madmadness65
5755180279
[Audio] Replace Graveyard BGM with Firel's custom BGM ( #4765 )
2024-10-30 21:48:09 -04:00
PrabbyDD
afe6d2900d
[P2] Fix for Speed Boost is Activated on the Turn a Pokemon is Switched In, and When a Pokemon Fails to Escape #4353 ( #4676 )
...
* fixing speed boost for pokemon being switched in and for if failed escape
* adding unit tests
* adding failed run away test case
* adding failed run away test case modification
* refactoring solution to be more consistent with coding style
* more fixes for consistency
* more fixes for consistency
* adding new AbAttr in abiliity.ts for posterity
* removing uneccesary variables
* fixing a merge conflict
2024-10-29 17:38:33 -04:00
Mumble
fb2d3e45d6
[Move][Ability] Fully Implement Forest's Curse / Trick Or Treat / Mimicry ( #4682 )
...
* addedType variable
* basic mimicry implementation
* eslint
* rage
* quick change
* made files
* added mimicry activation message
* test for moves done
* hahahhaha
* done? for now?
* laklhaflhasd
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* time to start... ughhh
* reflect type
* Added new message
* Update src/field/pokemon.ts
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* added overrides
* some checks
* removed comments
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-10-29 10:10:37 -07:00
PrabbyDD
3241332a3c
[Ability] Implementing Friend Guard ( #4718 )
...
* implementing friend guard ability
* Update src/data/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/data/ability.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/test/abilities/friend_guard.test.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/field/pokemon.ts
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
* more tests and fixing other issues
* more tests and fixing other issues
* Update Friend Guard test with damage mocks
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
Co-authored-by: innerthunder <brandonerickson98@gmail.com>
2024-10-28 13:49:04 -07:00
Frederico Santos
51b2a4d7fe
Something ( #4728 )
...
* [Feature] Add event-based friendship multiplier and update TrainerConfig for event modifiers
* [UI][Dev] Improve event banner placement (#4726 )
* [ui] automatically place event banner and timer in the title screen
* add new event banner
* ugh
* [Refactor] Clean up TrainerConfig and remove unused timed event
---------
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
2024-10-26 17:14:17 +01:00
PigeonBar
f87ac116fa
[Beta] Stop Transform giving copied moves negative fractional ppUp ( #4722 )
...
* [Beta] Stop Transform giving copied moves negative fractional `ppUp`
* Remove some bangs/etc
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-10-25 19:34:40 -04:00
Moka
a13550ec44
[Balance][ME] Various ME Balance changes ( #4700 )
...
* balance changes and updates to various MEs
* fix import to new item
* fix import to new item
* Update src/data/mystery-encounters/utils/encounter-pokemon-utils.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/phases/select-modifier-phase.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/modifier/modifier.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/modifier/modifier.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* revert item atlas changes
* eslint
* revert 'revert item atlas'
* update locale repo to latest commit
* Fix fiery fallout missing argument
* [balance] Training session ME does not update Seen/Defeated GameStats
* [balance] update Weird Dream ME maximum spawn wave
* [ME] update CombinationRequirements to allow AND or OR combinations
* refactor: CombinationPokemonRequirement `.Some()` and `Every()`
* chore: rename `orRequirements` to `requirements`
* fix: returns of `Some()` and `Any()`
* apply `Some()` / `Any()` pattern to `CombinationSceneRequirement` too
* revert 'offer you can't refuse' giving Silver Pokeball'
* Apply code review suggestions
* [me] Weird Dream: apply same old gateau logic to team in options 1 and 2
---------
Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
Co-authored-by: ImperialSympathizer <110984302+ben-lear@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: innerthunder <brandonerickson98@gmail.com>
2024-10-23 21:46:57 +02:00
innerthunder
03025b2674
[P2] Fix various charge move bugs ( #4595 )
...
* Add charge move classes and phase
* Integrate `MoveChargePhase` in battle phase sequence
* Fix Protean + charge move interaction
* Fix effect chance applying to semi-invulnerability
* Remove `ChargeAttr` and fix ChargeAnim loading
* Restore move history entry for charge phases
* Gravity now cancels Fly, etc. after charge turn
* Dig integration tests
* Fly integration tests
* Dive integration test + fix Dive in Harsh Sun bug
* Solar Beam integration tests + `CHARGING` tag fixes
* Fix dive test
* Electro Shot integration tests
* fix import in MoveChargePhase
* Electro Shot Multi Lens test
* Geomancy integration tests
* Fix duplicate move queue
* Update import
* Docs + Fix Meteor Beam being boosted by Sheer Force
* Fix volt absorb test
* Apply PigeonBar's suggested move-phase changes
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* Make Electro Shot Sheer Force boosted again
* Apply PigeonBar's feedback pt. 2
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fix mistimed/dupe showMoveText and leftover TODO
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
2024-10-23 11:08:40 -04:00
NightKev
181f59882a
[P2] Fix Early Bird ( #4632 )
...
* Fix Early Bird, add tests
* Update tsdocs for Early Bird's `AbAttr`
Rename `turnCount` to `toxicTurnCount` and
`turnsRemaining` to `sleepTurnsRemaining` in `status-effect.ts`
* Fix Toxic Orb test
* Redundant code :despair:
* Fix status override to set the number of sleep turns
2024-10-22 12:37:13 -04:00
Mason S
7066a15ceb
[Refactor] Added BattlerTagLapseType.AFTER_HIT ( #3655 )
...
* [Refactor] Added ON_GET_HIT BattlerTagLapseType
Adjusted BeakBlastChargingTag and ShellTrapTag to use new lapse type
Adjusted MoveEffectPhase to now lapse all tags with the ON_GET_HIT lapse type
* [Refactor] Added ON_GET_HIT BattlerTagLapseType
Adjusted BeakBlastChargingTag and ShellTrapTag to use new lapse type
Adjusted MoveEffectPhase to now lapse all tags with the ON_GET_HIT lapse type
* Fix nits
* Rename `ON_GET_HIT` to `AFTER_HIT`
Change `isOpponentTo` to `isOpponent`
* Fix a couple minor nits
* Remove single-use function
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-10-21 23:53:00 -07:00
innerthunder
c2eb9de9df
[Ability] Partially Implement Infiltrator (does not work with mist) ( #4636 )
...
* Implement Infiltrator
* Integration tests + Infiltrator is (P) again
* Fix screen tests
* Fix `hitsSubstitute`
* docs for Infiltrator attr
2024-10-21 21:41:25 -04:00
NightKev
966b07f62b
[Misc] Shiny overrides can now force Pokemon to not be shiny ( #4699 )
...
Also fixes random shinies breaking tests
2024-10-21 11:00:58 -04:00
MokaStitcher
e6c06d57be
[P All][Bug] Various ME bugfixes (copy) ( #4695 )
...
* Mystery Encounter bugfixes
* more ME bug fixes
* update allowed pokemon in ME requirements
* some unit test cleanup and general tidying
* fix null exception on isBattleMysteryEncounter
* clean up tsdocs and fix pokemon hasAbility check
* fix double battle crash in challenge mode with a single eligible pokemon
* apply suggestions from PR#4619's code reviews
* revert fix for Keldeo crashes + implement fix suggestion from PR #4619
* fix session migration for PokemonCustomData
* prevent test failure due to keldeo fix
---------
Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-10-20 22:55:07 +01:00
NightKev
39abac65be
Add eslint rule to enforce indenting of case statements ( #4692 )
2024-10-20 02:44:36 +01:00
AJ Fontaine
d5fee37868
[Refactor] Add friendship related constants ( #4657 )
...
* Add constants for friendship
* Absolute path in battle-scene.ts
* Address nits
* Apply negative to constant
2024-10-16 14:55:23 -04:00
PigeonBar
50ff6e703a
[P1 Bug] Fix several Destiny Bond crashes ( #4665 )
...
* [P1 Bug] Fix several Destiny Bond crashes
* PR Feedback
2024-10-16 10:30:38 -04:00
